Make sure generate the 'OnIdle' event when there are other subscribers #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzybkr
approved these changes
Apr 18, 2019
There was a problem hiding this comment.
If I'm reading git blame correctly, this scenario never really worked - I'm surprised it took so long for someone to notice.
It took me a minute to understand why the break was causing a problem, so maybe you could add a comment to make it clear.
Alternatively (I'm not sure it would be easy) - you could add a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #827
Make sure we generate the 'OnIdle' event when there are other subscribers.
After the fix, 'OnIdle' event registered after other event subscribers works: