Fix for getting signed urls

[pbteja1998]

Notion API is throwing an error when a signed URL is requested for page cover. Removing it solves the problem.

Resolves #331

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
react-notion-x	✅ Ready (Inspect)	Visit Preview	Jul 27, 2022 at 4:24PM (UTC)
react-notion-x-minimal-demo	✅ Ready (Inspect)	Visit Preview	Jul 27, 2022 at 4:24PM (UTC)

[transitive-bullshit]

Won't this break user-uploaded page covers which need to be signed?

[pbteja1998]

I am using this patch in feather.so and so far it is working well even for user uploaded covers. My guess is user uploaded covers were not needed to be signed in the first place.

[pbteja1998]

I just tried it locally, the covers are showing up even if they are user-uploaded.

[remorses]

Your PR still fails with pages like this one (the link is using code from your pr)
https://react-notion-x-minimal-demo-git-fork-pbteja1998-patch-2-saasify.vercel.app/5af3d63c840e458e92c09c2ec6cd71b3

The problem is that the signed urls endpoint no longer accepts any host and only accepts domains with host secure.notion-static.com (and moaybe also other hosts i dont know about)

This means that if you have any embed on the page addSignedUrls will fail because it passes the embed url to the endpoint (in the page about it passes the loom video url)

In simple cases your pr works because it does not pass the cover url to signed urls endpoint

[pbteja1998]

@remorses can you check your example now?

[normdoow]

Is this a different way to fix the same problem as this fixes? #332

[pbteja1998]

@normdoow yes

[transitive-bullshit]

Going with #332 over this PR as I think it's the safer option.