Only add signed urls for secure.notion-static.com urls
#332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
remorses
commented
Jul 25, 2022
| @@ -235,7 +235,7 @@ export class NotionAPI { | |||
| // console.log(block, source) | |||
|
|
|||
| if (source) { | |||
| if (source.indexOf('youtube') >= 0 || source.indexOf('vimeo') >= 0) { | |||
| if (!source.includes('secure.notion-static.com')) { | |||
There was a problem hiding this comment.
I always only encountered urls with secure.notion-static.com that needed to be signed, there may be more endpoints than this one
|
This fixed some issues for me as well where uploaded videos weren't showing up. Like this page for example: 849918ea9a9144ba9b84d70d512274ab Trying to understand the full scope of changes that this will have before merging in. Thanks! |
|
I've done some more testing and this seems to work well and not break anything. |
|
I think this is the best fix for the issue. Thanks @remorses 🙏 |
chuyun
pushed a commit
to chuyun/react-notion-x
that referenced
this pull request
Jul 13, 2023
Only add signed urls for `secure.notion-static.com` urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only add signed urls for
secure.notion-static.comurlsFix #331
Notion Test Page ID
https://brave-iberis-6ea.notion.site/Videos-5af3d63c840e458e92c09c2ec6cd71b3
https://react-notion-x-demo.transitivebullsh.it/5af3d63c840e458e92c09c2ec6cd71b3