Skip to content

BasicDragger.java Bug Fix #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

BasicDragger.java Bug Fix #6

wants to merge 2 commits into from

Conversation

faa
Copy link

@faa faa commented Apr 5, 2016

Hi,

I was working with Dzuy and Matt on this issue. The cursor was moving off of the ground symbols while dragging when zoomed in. I wrote up the fix for the ground symbols.

Thanks.

@mbudk
Copy link

mbudk commented Sep 23, 2016

I still have issues using this version (symbol not following mouse cursor). It seems like a regression in BasicDragger. Using versions prior to svn version 649 works (e.g. rev 459). See old svn repo: https://worldwind31.arc.nasa.gov/svn/trunk/WorldWind/src/gov/nasa/worldwind/util

EDIT: created my own pull request #20

@zglueck
Copy link
Contributor

zglueck commented Sep 24, 2016

Thanks @faa for contributing your work in this pull request. We've conducted a comprehensive refactor of the BasicDragger to correct the behavior which is detailed in commit f67dee9. The new approach provides a Draggable interface which moves drag execution to the object itself. We've also provided utility methods which correct the behavior observed in the DraggableSupport class. All World Wind objects implementing Movable or Movable2 have also incorporated Draggable and the appropriate utility functions which correct the erroneous dragging behavior. Again, thanks for providing your approach and we hope the new interface serves you well.

@zglueck zglueck closed this Sep 24, 2016
@faa
Copy link
Author

faa commented Oct 7, 2016

@zglueck Thanks, I will pull down the latest code and try it out.

@zglueck zglueck mentioned this pull request Nov 16, 2016
2 tasks
@pdavidc pdavidc added this to the v2.1.0 milestone Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants