Skip to content

BasicDragger terrain regression fix #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

BasicDragger terrain regression fix #20

wants to merge 1 commit into from

Conversation

mbudk
Copy link

@mbudk mbudk commented Sep 23, 2016

Fixed mousecursor not on top of dragObject. This bug seems like a regression introduced in svn version 649. Merged svn versions 459 and 2291 without reintroducing the bug.

This bug seems like a regression introduced in svn version 649. Merged svn versions 459 and 2291 without reintroducing the bug.
@mbudk mbudk mentioned this pull request Sep 23, 2016
@mbudk
Copy link
Author

mbudk commented Sep 23, 2016

I still had issues with pull request #6, hence this new request.

@zglueck
Copy link
Contributor

zglueck commented Sep 23, 2016

Thanks @mbudk for this effort. We actually have a comprehensive BasicDragger overhaul in the pipeline. It will introduce a new interface and shift the implementation away from BasicDragger. It also corrects the behavior of objects drifting from the cursor. The design is still in review, and until it's ready, I'd like to leave this pull request open in case it helps others out while the new BasicDragger is being vetted. Thanks again for sharing your code and hopefully the new BasicDragger (when it is ready) will solve your issues!

@zglueck
Copy link
Contributor

zglueck commented Sep 24, 2016

@mbudk, thanks again for submitting your work on correcting the behavior of the BasicDragger. The commit f67dee9 on the master branch adds a new Draggable interface which allows you to define dragging behavior in the class itself. We've also provided utility methods which correct the cursor drifting from the object in the DraggableSupport class that was added in the same commit. Existing World Wind objects now implement the Draggable interface and the appropriate drag utility methods from DraggableSupport, hopefully correcting the dragging issues you observed.

@zglueck zglueck closed this Sep 24, 2016
@mbudk
Copy link
Author

mbudk commented Sep 26, 2016

@zglueck, thank you. I've tested on daily 1886 and BasicDragger seems to work fine on terrain now, thanks again. I did need to enable dragging on a PointPlacemark based object of mine to get it working. I also have a SurfacePolyline I'm dragging, on that dragging was enabled by default (in AbstractSurfaceShape). I'm probably missing something, but shouldn't the dragging enabled default policy be the same across renderables (to me, false seems like the best default)?

@zglueck
Copy link
Contributor

zglueck commented Sep 26, 2016

@mbudk you are correct, I forgot to initialize properly on PointPlacemark, it should indeed be enabled by default. Thanks for catching this, the fix is in commit 6584066.

@zglueck zglueck mentioned this pull request Nov 16, 2016
2 tasks
@pdavidc pdavidc added the bug label Dec 9, 2016
@pdavidc pdavidc added this to the v2.1.0 milestone Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants