Skip to content

Relax restriction of one label per issue #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghuntley opened this issue Nov 6, 2016 · 4 comments
Open

Relax restriction of one label per issue #90

ghuntley opened this issue Nov 6, 2016 · 4 comments
Milestone

Comments

@ghuntley
Copy link

ghuntley commented Nov 6, 2016

Over at ReactiveUI we are not using the standard convention of:

- Bug
- Feature
- Improvement
- Performance

Instead, because the product targets so many platforms we use a convention of one label per platform:

- ReactiveUI Core
- ReactiveUI Events
- UWP
- Xamarin Android
- Xamarin Mac
- Xamarin iOS
- WPF
- WinForms
- Housekeeping

Currently GitReleaseManager has a restriction of one label per issue, in some cases a single GitHub issue will affect multiple platforms and thus would like to see that issue appearing multiple times in our release notes (i.e. once under Xamarin.Mac and once under Xamarin.iOS)

ITT we discuss design before sending in a PR.

@RichiCoder1
Copy link

Ditto. With Chocolatey GUI we categorize both by Type (Bug/Improvement/Feature), and Category (UI, Infrastructure, Chocolatey).

@RichiCoder1
Copy link

RichiCoder1 commented Feb 15, 2017

@ghuntley @gep13 I don't imagine this will be overly difficult to fix, so I'm thinking about doing a PR for this. Idea would be that there are these potential scenarios:

  • Issue has no labels --> Exclude
  • Issue has one label:
    • Label is excluded or doesn't match an included label or alias --> Exclude
    • Label is included --> Include and associate with label
  • Issue has multiple labels:
    • No label matches an included label or alias --> Exclude
    • Only one label matches included label or alias --> Include and associate with label
    • Multiple labels match an included label or alias --> This is where it gets fuzzy. Should we include it based on the first matching label? Should we file it under every relevant label? Should we just excluded it? And if excluded, should it be silent or throw a warning or error?

@tbeu
Copy link

tbeu commented Mar 30, 2017

This current restriction is a real show-stopper. Unfortunately there is no other tool to automatically create release notes from a milestone.

@ghuntley
Copy link
Author

ghuntley commented Sep 4, 2017

#upforgrabs - watch dis video for more information

robertlyson added a commit to robertlyson/GitReleaseManager that referenced this issue Sep 26, 2017
Previously GitReleaseManager wasn't able to generate release note for issues with multiple labels.
With this change it's become possible, but additional configuration flag needs to be set.
gep13 pushed a commit to robertlyson/GitReleaseManager that referenced this issue Aug 8, 2018
Previously GitReleaseManager wasn't able to generate release note for issues with multiple labels.
With this change it's become possible, but additional configuration flag needs to be set.
@gep13 gep13 added this to the 0.12.0 milestone Jan 6, 2020
@gep13 gep13 modified the milestones: 0.12.0, 0.13.0 Mar 16, 2020
@gep13 gep13 modified the milestones: 0.13.0, Future Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants