Skip to content

Branches containing a slash break v4 branch endpoints. #263 #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

b0nd0
Copy link
Contributor

@b0nd0 b0nd0 commented Nov 21, 2017

Hello.
This is my attempt to fix #263.

I tested only Delete branch endpoint, cause this is the only one we are using here right now.
I completely removed encodeBranch function being guided by #86 pull request, which we kinda reverting now.

upd:
by "tested" i mean on real gitlab installation, not just unit.

@b0nd0
Copy link
Contributor Author

b0nd0 commented Nov 29, 2017

any thoughts?

@fbourigault fbourigault merged commit 84ce65a into GitLabPHP:master Nov 29, 2017
@fbourigault
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Branches containing a slash break v4 branch endpoints
2 participants