Skip to content

Branches containing a slash break v4 branch endpoints #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vetruvet opened this issue Oct 4, 2017 · 1 comment · Fixed by #276
Closed

Branches containing a slash break v4 branch endpoints #263

vetruvet opened this issue Oct 4, 2017 · 1 comment · Fixed by #276

Comments

@vetruvet
Copy link
Contributor

vetruvet commented Oct 4, 2017

The encoding of branch names in API v4 has changed from unencoded slashes to encoded as "%2f". As such, getting branch information for a branch like "env/production" is broken in the latest version.

Ironically this means #86 basically needs to be reverted.

Removing the str_replace call in Repositories fixes the issue for me but I'm not sure if there are any other places where this needs to be done.
@fbourigault
Copy link
Contributor

Could you open a PR to fix this? If we find other places later we will do more fixes.

b0nd0 added a commit to b0nd0/php-gitlab-api that referenced this issue Nov 21, 2017
@b0nd0
Branches containing a slash break v4 branch endpoints. GitLabPHP#263
311cb42
@b0nd0 b0nd0 mentioned this issue Nov 21, 2017
Merged
fbourigault added a commit that referenced this issue Nov 29, 2017
@fbourigault
Merge pull request #276 from b0nd0/master
84ce65a 
Branches containing a slash break v4 branch endpoints. #263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Branches containing a slash break v4 branch endpoints. #263 b0nd0/php-gitlab-api
2 participants
@vetruvet @fbourigault