fix(ci): pin importlib_metadata<5.0.0 #4257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majorgreys
added
the
changelog/no-changelog
Kyle-Verhoog
previously approved these changes
Oct 3, 2022
mabdinur
previously approved these changes
Oct 3, 2022
Yun-Kim
previously approved these changes
Oct 3, 2022
|
@Mergifyio backport 1.5 1.4 0.61 |
✅ Backports have been created
|
|
https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/21692/workflows/9e343c62-7932-40fb-80b3-4de4473d7eed/jobs/1477305 looks like it's still failing 🤔 |
jd
previously approved these changes
Oct 4, 2022
|
It'd be great to track the upstream issue (I imagine it's one of the dependencies we pull that breaks with 5.0.0, not our code). |
Added open issue on the breaking change. |
✅ Backports have been created
|
majorgreys
force-pushed
the
majorgreys/ci-pin-importlib
branch
from
47b6a59 to
21509fe
Compare
majorgreys
force-pushed
the
majorgreys/ci-pin-importlib
branch
from
21509fe to
785976d
Compare
majorgreys
dismissed stale reviews from jd, Yun-Kim, mabdinur, and Kyle-Verhoog
via
5edda43
majorgreys
force-pushed
the
majorgreys/ci-pin-importlib
branch
from
392f750 to
81e4de2
Compare
majorgreys
force-pushed
the
majorgreys/ci-pin-importlib
branch
from
a29a762 to
1830fc6
Compare
mabdinur
previously approved these changes
Oct 5, 2022
brettlangdon
previously approved these changes
Oct 5, 2022
|
As a follow-up, we can look into enabling the profile-windows jobs with the updated image. cc @jd |
Kyle-Verhoog
previously approved these changes
Oct 5, 2022
Co-authored-by: Kyle Verhoog <[email protected]>
majorgreys
dismissed stale reviews from Kyle-Verhoog, brettlangdon, and mabdinur
via
50d4619
mabdinur
approved these changes
Oct 5, 2022
Kyle-Verhoog
approved these changes
Oct 5, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
CI jobs `profile-windows-*`, `kombu` and `celery` are failing due to the release of `importlib_metadata==5.0.0` which removed deprecated shims, resulting in the following exception: ``` AttributeError: 'EntryPoints' object has no attribute 'get' ``` We fix this by pinning the dependency for kombu and celery. In the case of the Windows tests, we address it by upgrading the Windows image to a version that includes Python 3.10 rather than Python 3.7 which removes the need to install the dependency when installing tox. - [Example log of failing job](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/21679/workflows/2a7606b5-9ca8-4212-9b02-053665de0198/jobs/1477147) - python/importlib_metadata#409 (cherry picked from commit c2b416e)
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
CI jobs `profile-windows-*`, `kombu` and `celery` are failing due to the release of `importlib_metadata==5.0.0` which removed deprecated shims, resulting in the following exception: ``` AttributeError: 'EntryPoints' object has no attribute 'get' ``` We fix this by pinning the dependency for kombu and celery. In the case of the Windows tests, we address it by upgrading the Windows image to a version that includes Python 3.10 rather than Python 3.7 which removes the need to install the dependency when installing tox. - [Example log of failing job](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/21679/workflows/2a7606b5-9ca8-4212-9b02-053665de0198/jobs/1477147) - python/importlib_metadata#409 (cherry picked from commit c2b416e)
This was referenced Oct 6, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
CI jobs `profile-windows-*`, `kombu` and `celery` are failing due to the release of `importlib_metadata==5.0.0` which removed deprecated shims, resulting in the following exception: ``` AttributeError: 'EntryPoints' object has no attribute 'get' ``` We fix this by pinning the dependency for kombu and celery. In the case of the Windows tests, we address it by upgrading the Windows image to a version that includes Python 3.10 rather than Python 3.7 which removes the need to install the dependency when installing tox. - [Example log of failing job](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/21679/workflows/2a7606b5-9ca8-4212-9b02-053665de0198/jobs/1477147) - python/importlib_metadata#409 (cherry picked from commit c2b416e) # Conflicts: # .circleci/config.yml
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
CI jobs `profile-windows-*`, `kombu` and `celery` are failing due to the release of `importlib_metadata==5.0.0` which removed deprecated shims, resulting in the following exception: ``` AttributeError: 'EntryPoints' object has no attribute 'get' ``` We fix this by pinning the dependency for kombu and celery. In the case of the Windows tests, we address it by upgrading the Windows image to a version that includes Python 3.10 rather than Python 3.7 which removes the need to install the dependency when installing tox. - [Example log of failing job](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/21679/workflows/2a7606b5-9ca8-4212-9b02-053665de0198/jobs/1477147) - python/importlib_metadata#409 (cherry picked from commit c2b416e) # Conflicts: # .circleci/config.yml
Kyle-Verhoog
added a commit
that referenced
this pull request
Oct 6, 2022
CI jobs `profile-windows-*`, `kombu` and `celery` are failing due to the release of `importlib_metadata==5.0.0` which removed deprecated shims, resulting in the following exception: ``` AttributeError: 'EntryPoints' object has no attribute 'get' ``` We fix this by pinning the dependency for kombu and celery. In the case of the Windows tests, we address it by upgrading the Windows image to a version that includes Python 3.10 rather than Python 3.7 which removes the need to install the dependency when installing tox. - [Example log of failing job](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/21679/workflows/2a7606b5-9ca8-4212-9b02-053665de0198/jobs/1477147) - python/importlib_metadata#409 (cherry picked from commit c2b416e) Co-authored-by: Tahir H. Butt <[email protected]> Co-authored-by: Kyle Verhoog <[email protected]>
Kyle-Verhoog
pushed a commit
that referenced
this pull request
Oct 12, 2022
CI jobs `profile-windows-*`, `kombu` and `celery` are failing due to the release of `importlib_metadata==5.0.0` which removed deprecated shims, resulting in the following exception: ``` AttributeError: 'EntryPoints' object has no attribute 'get' ``` We fix this by pinning the dependency for kombu and celery. In the case of the Windows tests, we address it by upgrading the Windows image to a version that includes Python 3.10 rather than Python 3.7 which removes the need to install the dependency when installing tox. - [Example log of failing job](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/21679/workflows/2a7606b5-9ca8-4212-9b02-053665de0198/jobs/1477147) - python/importlib_metadata#409 (cherry picked from commit c2b416e) Co-authored-by: Tahir H. Butt <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
|
@Mergifyio backport 0.61 |
✅ Backports have been created
|
Kyle-Verhoog
pushed a commit
that referenced
this pull request
Oct 24, 2022
* fix(ci): pin importlib_metadata<5.0.0 (#4257) CI jobs `profile-windows-*`, `kombu` and `celery` are failing due to the release of `importlib_metadata==5.0.0` which removed deprecated shims, resulting in the following exception: ``` AttributeError: 'EntryPoints' object has no attribute 'get' ``` We fix this by pinning the dependency for kombu and celery. In the case of the Windows tests, we address it by upgrading the Windows image to a version that includes Python 3.10 rather than Python 3.7 which removes the need to install the dependency when installing tox. - [Example log of failing job](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/21679/workflows/2a7606b5-9ca8-4212-9b02-053665de0198/jobs/1477147) - python/importlib_metadata#409 (cherry picked from commit c2b416e) # Conflicts: # .circleci/config.yml * fix conflicts Co-authored-by: Tahir H. Butt <[email protected]> Co-authored-by: Munir Abdinur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI jobs
profile-windows-*,kombuandceleryare failing due to the release ofimportlib_metadata==5.0.0which removed deprecated shims, resulting in the following exception:We fix this by pinning the dependency for kombu and celery. In the case of the Windows tests, we address it by upgrading the Windows image to a version that includes Python 3.10 rather than Python 3.7 which removes the need to install the dependency when installing tox.