chore(gevent): disable gevent hub reinit #4252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabdinur
added
the
changelog/no-changelog
Kyle-Verhoog
reviewed
Oct 3, 2022
mabdinur
commented
Oct 3, 2022
mabdinur
commented
Oct 3, 2022
|
@Mergifyio backport 1.5 |
✅ Backports have been created
|
Kyle-Verhoog
approved these changes
Oct 3, 2022
Yun-Kim
approved these changes
Oct 3, 2022
Kyle-Verhoog
deleted the
munir/ddtrace-disable-gevent-hub-reinit-default
branch
14 tasks
Kyle-Verhoog
pushed a commit
that referenced
this pull request
Oct 3, 2022
Adds release note for the following change: #4252
mergify bot
added a commit
that referenced
this pull request
Oct 6, 2022
This is an automatic backport of pull request #4252 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-initialize the gevent hub after-in-child fork hooks when
DD_TRACE_GEVENT_HUB_PATCHEDis set to true. This mitigates a performance regression introduced by: #4070.Note: This PR simply mitigates the performance regression introduced by #4070. Reinitializing gevent patching when a process forks is required to use remote config, the profiler and debugger. This issue will be fixed in a follow up change.
Checklist
featandfixpull requests.Motivation
Design
Testing strategy
Relevant issue(s)
Testing strategy
Reviewer Checklist
changelog/no-changeloglabel added.