Skip to content

Add automatic testing of responses to empty messages #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2017

Conversation

neiljp
Copy link
Contributor

@neiljp neiljp commented Dec 9, 2017

This is an alternative testing-based (rather than default-behavior-based) approach to #58, which also could fix #55 - though again, via tests (test_lib.py), rather than lib.py.

This follows the idea I saw introduced with test_bot_usage. I ended up overriding the function in a few bots, though I had originally planned to keep it as local to test_lib.py as possible.

@showell You seem to be taking a lead on tests atm, so tagging you for review/comments.

@zulipbot
Copy link
Member

zulipbot commented Dec 9, 2017

Hello @neiljp, it seems like you have referenced an issue in your pull request, but you have not referenced that issue in your commit message(s). When you reference an issue in a commit message, it automatically closes the corresponding issue when the commit is merged.

Please run git commit --amend in your command line client to amend your commit message description with "Fixes #[issue number]”.

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51

Thank you for your contributions to Zulip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle empty bot messages through the bots framework.
3 participants