(chore): release notes cleanup

[ilan-gold]

oops on us @dstansby!
TODO:

• Add unit tests and/or doctests in docstrings
• Add docstrings and API docs for any new/modified user-facing classes and functions
• New/modified features documented in docs/user-guide/*.rst
• Changes documented as a new file in changes/
• GitHub Actions have all passed
• Test coverage is 100% (Codecov passes)

[dstansby]

Huh, odd - I wonder why towncrier didn't pick these up when I ran it?

[ilan-gold]

@dstansby towncrier matches exactly on the type of issue, I believe, if memory serves, probably. Mine was titled fix and the other was misspelled, I think, so it didn't recognize them as fragments.

[dstansby]

Ah that would explain it. I wonder if there's a way we can catch these and error on CI before release... anyway, thanks for the fix here!

[d-v-b]

Ah that would explain it. I wonder if there's a way we can catch these and error on CI before release... anyway, thanks for the fix here!

Could the "needs release notes" label check for valid (releasable) release notes?

[dstansby]

Looks like twisted/towncrier#137 is a relevant issue

[ilan-gold]

@dstansby We also use towncrier in anndata and I think we essentially have the same issue. The "best" we do is calling towncrier before actually building the docs so we can in theory (big emphasis there) check:

https://github.com/scverse/anndata/blob/bb2d44c0ad5757c5fc59844e2cf686009bb6073d/.readthedocs.yml#L10-L12

[ilan-gold]

You could actually probably edit that regex so it fails upon finding a non-supported md file (in our case).