Resolve Git dependencies offline if tarball is available. #3000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
reviewed
Apr 19, 2017
There was a problem hiding this comment.
Hi @raymondwang! Thanks for this PR, it looks pretty good! Would you mind fixing my nit comment and rebasing your work on the master branch?
| @@ -201,7 +201,7 @@ export default class HostedGitResolver extends ExoticResolver { | |||
| // If we can access the files over HTTP then we should as it's MUCH faster than git | |||
| // archive and tarball unarchiving. The HTTP API is only available for public repos | |||
| // though. | |||
| if (await this.hasHTTPCapability(httpUrl)) { | |||
| if (this.request.getLocked('tarball') || await this.hasHTTPCapability(httpUrl)) { | |||
There was a problem hiding this comment.
It works, but I think it would make more sense semantically speaking to just move those lines at the beginning of the resolve() function instead.
There was a problem hiding this comment.
Yes, sounds good to me!
When running yarn offline, Git dependencies get trapped in hasHTTPCapabiity even though resolveOverHTTP defaults to returning the tarball. This change allows us to bypass that step altogether if the tarball already exists.
|
@arcanis Done! |
|
Thanks! |
|
I am correct in assuming that this is not part of the just released yarn 0.23.4? Because that one still fails for me with the "--offline" flag. If so, what release would this be included in then? |
|
Yes. It will be released in the 0.24, which we want to publish later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When running yarn offline, Git dependencies get trapped in
hasHTTPCapabilityeven thoughresolveOverHTTPdefaults to returning the tarball. This change allows us to bypass that step altogether if the tarball already exists.Resolves #1925.
Test plan
Create a
package.jsonwith a Git dependency, like:Then:
This should fail prior to this commit, but succeed after.
This change was first proposed in #2705, but @chrisgavin closed the PR and hasn't had a chance to revisit. I'm happy to add unit tests if/as needed, but may need some guidance on mocking offline functionality.