Fix typo in PATH added by Windows installer #2631
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change PATH from `%LocalAppData%\Yarn\.bin` to `%LocalAppData%\Yarn\config\global\node_modules\.bin` in the Windows installer * Fixes the Windows PATH introduced in c091ac4 & yarnpkg#1129 * Allows global packages to be accessible through Windows PowerShell and CMD
Daniel15
requested changes
Feb 5, 2017
There was a problem hiding this comment.
I feel like the path in the installer is correct, and Yarn is actually using the wrong path. Globally installed modules shouldn't be going into a "config" directory 😛
Could you please update it to add both* paths? I think you'd need two separate <Environment /> elements to do that.
|
@neojp Are you interested in addressing the review comments? The issue still affects users so it would be great to get this fixed! |
|
This was fixed by #3233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Global packages are currently not accessible through the command line because the PATH has been wrongly set through the Windows Installer c091ac4 & #1129
This gives the impression that global packages don't work on Windows at all and has been brought up in issue #2192 (comment)
Test plan
This has been tested to work on the original PR #1129. This should just fix a typo in the PATH.