fix(core): let semver try to match first in satisfiesWithPrereleases
#3133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
reviewed
Jul 26, 2021
| @@ -43,6 +43,9 @@ const SPECS: Specs = [ | |||
| [`1.0.0-rc2`, `1.0.0-rc4`, false], | |||
| [`1.0.0-rc4`, `1.0.0-rc2`, false], | |||
| [`1.0.0-beta.1`, `1.0.0-beta.2`, false], | |||
|
|
|||
| // These don't match with our patch but do without it | |||
There was a problem hiding this comment.
I don't understand this comment 😅
There was a problem hiding this comment.
Yeah, the wording is horrible but the gist of it is that before this PR semverUtils.satisfiesWithPrereleases(version, range) didn't match while semver.satisfies(version, range, {includePrerelease: true}) does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Some of the extensions added in #3082 didn't get applied since
satisfiesWithPrereleasesdidn't match them correctlyHow did you fix it?
Let
semversee if the version satisfies the range and if it doesn't run our loose checkChecklist