Add VSCode support for Stylelint to PnPify tool. #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phyllisstein
changed the title
This was referenced Mar 1, 2020
|
Sounds good, but can you open the PR on PostCSS-Syntax before I merge this one? Also, looking at their README, I think that optional peer dependencies might be a better fit than regular dependencies (since they ask their users to add the various modules themselves). |
|
@arcanis seems that @phyllisstein had opened PR into postcss-syntax gucong3000/postcss-syntax#46 May we merge this PR? |
|
Pardon the radio silence here. I wound up dropping back down to Yarn Classic in my project, then got slammed with onboarding for a new gig. I'll make time this weekend to take another look. |
|
@phyllisstein @arcanis I rebased this PR on master in #1263 |
|
Thank you both! 😃 |
|
Thanks for picking up my slack. Onboarding in quar is no small thing. 😩 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Currently, Berry breaks support for the VSCode Stylelint plugin in much the same way that it caused issues with ESLint and TSC.
How did you fix it?
This change updates the SDK support script in
@yarnpkg/pnpifyto generate a PnP wrapper for Stylelint and point the project's VSCode config file to the script. It also updates thecompatplugin so that a Stylelint dependency,postcss-syntax, can require some additional packages which it currently only includes in itsdevDepdendencies. (PR addressing the issue in that repo to follow.)