Skip to content

Adding support for dates #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Adding support for dates #2

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 9, 2014

Will this be of use?

@yahoocla
Copy link

yahoocla commented Dec 9, 2014

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@yf-hk
Copy link

yf-hk commented Feb 5, 2015

+1 for adding date support

@caridy
Copy link
Contributor

caridy commented Feb 5, 2015

@ppallesws can you sign the CLA?

@caridy
Copy link
Contributor

caridy commented Feb 5, 2015

/cc @ericf @jlecomte

@ghost
Copy link
Author

ghost commented Feb 5, 2015

Sure. System reply...Good to see you, Pete Palles

You previously signed this CLA on:
Tue Dec 09 2014 21:08:01 GMT+0000 (UTC)


Pete Palles
RevTechPlus
Director of Technology
Cell: (570) 640-9589
www.revtechplus.com

On Thu, Feb 5, 2015 at 9:47 AM, Caridy Patiño [email protected]
wrote:

/cc @ericf https://github.com/ericf @jlecomte
https://github.com/jlecomte


Reply to this email directly or view it on GitHub
#2 (comment)
.

@ericf
Copy link
Collaborator

ericf commented Feb 5, 2015

@ppallesws Thanks for doing this! Would you be up for adding unit tests for this new date support?

@ghost
Copy link
Author

ghost commented Feb 5, 2015

Sure, I can give it a look this evening if no urgency.


Pete Palles
RevTechPlus
Director of Technology
Cell: (570) 640-9589
www.revtechplus.com

On Thu, Feb 5, 2015 at 12:03 PM, Eric Ferraiuolo [email protected]
wrote:

@ppallesws https://github.com/ppallesws Thanks for doing this! Would
you be up for adding unit tests for this new date support?


Reply to this email directly or view it on GitHub
#2 (comment)
.

@ericf
Copy link
Collaborator

ericf commented May 5, 2016

This approach won't work, see #16

@ericf ericf closed this May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants