Skip to content

Futurize pass 1 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 24, 2022
Merged

Futurize pass 1 #11

merged 9 commits into from
Nov 24, 2022

Conversation

ydirson
Copy link
Contributor

@ydirson ydirson commented Jul 28, 2022

This includes:

  • the pass 1 run itself
  • fixing things futurize breaks
  • avoiding the use of future in favor of six (future should not have appeared it anyway, as I read the definition of pass 1)
  • cleanup changes from with pylint help

@ydirson ydirson force-pushed the futurize-pass-1 branch 4 times, most recently from 0989e42 to 75874f1 Compare July 29, 2022 15:39
@psafont psafont self-requested a review August 9, 2022 08:28
@ydirson ydirson force-pushed the futurize-pass-1 branch 9 times, most recently from 8e32a43 to 0517d9c Compare August 12, 2022 09:16
@ydirson ydirson force-pushed the futurize-pass-1 branch 4 times, most recently from 4f5b8f8 to 3c4c57f Compare August 29, 2022 16:03
@edwintorok
Copy link
Contributor

This is a stacked PR, compare commits for just this PR: ydirson/xenserver-python-libs@improve-test-coverage...ydirson:xenserver-python-libs:futurize-pass-1

@edwintorok
Copy link
Contributor

@ydirson ydirson force-pushed the futurize-pass-1 branch 3 times, most recently from 799654e to edc16d6 Compare September 26, 2022 11:47
@ydirson ydirson mentioned this pull request Sep 26, 2022
Note there are indentation issues introduced in xcp.repository, as well
as uses of the `future` package (which are not supposed to happen in
pass 1), and several smaller issues.  All of this is handled separately
in further patches, so we can easily reconstruct this patch by running
`futurize -wn1`.

Signed-off-by: Yann Dirson <[email protected]>
@psafont psafont merged commit c641ca3 into xenserver:master Nov 24, 2022
bernhardkaindl added a commit to rosslagerwall/python-libs that referenced this pull request May 8, 2024
…/systemd-tar-subarchive

CP-45506: Archive /etc/systemd as tar archive inside the output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants