-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Reland JSON module scripts #5658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
914e7d5
Reland JSON modules
dandclark b058240
Add import attribute type checks and initial plumbing.
dandclark d0137f5
Plumb through ModuleRequest instead of string for 'fetch an import() …
dandclark b2e7065
Don't cache a null entry in the module map in the case where the MIME…
dandclark 0cbf597
Allow modulepreload to work for all module types without needing to s…
dandclark 6932074
After rebase, fix build break from name change to JSON.Parse in https…
dandclark 1f83c7e
Fix typo in JSON modules example and add note on requiring JSON MIME …
dandclark a3621dd
Update ModuleRequest definition to reference the import-attributes pr…
dandclark 55ebd12
Revert added null check in 'fetch a modulepreload module script graph…
dandclark af41b28
Reference ParseJSONModule from import-attributes proposal instead of …
dandclark a2d4260
Cache an entry in the module map if the fetched module was valid but …
dandclark f79c01f
Extend note to be clear that the module must have no effect until a r…
dandclark 7c900a1
When a valid MIME type is received that doesn't match the requested t…
dandclark 55c9ed9
Wrap <p class=note> in <li> so it's not directly under an <ol>, which…
dandclark 322808d
Whitespace change: remove double spaces after sentences in notes. Ho…
dandclark 43e6fe3
Merge branch 'upstream-master' into dandclark/import-attributes
dandclark 9f2ae27
Reword invocations of 'create a module script with matching type' to …
dandclark e86dd65
Change 'fetch a single module script' to fail if there are any unrec…
dandclark 3318ed3
Instead of passing fetch response parameter to 'create a module scrip…
dandclark 3c0dce2
Add assert that 'create a module script with matching type' is not ru…
dandclark 1c9df5a
Reword caching comment
dandclark 3247e99
Handle rename in TC39 proposal from import attributes to import condi…
dandclark dca376b
Update for the latest rename of the proposal from 'Import Conditions'…
dandclark e3359b5
Use module type as part of module map cache key instead of caching re…
dandclark 0857ec8
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
dandclark aafb256
Change 'abort these steps' to 'return' to match recent changes in 'fe…
dandclark 9164acf
Remove JSON modules references, switch JavaScript module script refer…
dandclark 9eda0e2
Properly return non-null module map entry if one already exists.
dandclark 9fbbc6d
Update spec links to reflect split of import assertions and json modules
dandclark a8cb4a9
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
dandclark f53c203
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
dandclark 1117dc3
Update module map dfn note to explain purpose of having module type i…
dandclark 73f2be2
Update module map dfn note to explain purpose of having module type i…
dandclark eec60c5
Ignore unknown import assertions instead of failing. Continue failing…
dandclark 6ed4474
Ignore unknown import assertions instead of failing. Continue failin…
dandclark c225d56
Move check for unknown type assertion to 'create a module script'.
dandclark 2448342
Move check for unknown type assertion to 'create a module script'.
dandclark 6a160fe
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
dandclark 1566bc0
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
dandclark 3c94b31
Review feedback: use tuple instead of pair, improve module map defini…
dandclark 9da92b5
Review feedback: Link to memory cache issue, null --> 'javascript' ty…
dandclark 26c2b81
Remove duplicated words
dandclark 4ad7d2d
Move quotes outside of <code> elements.
dandclark 614a9f4
Add HostGetSupportedAssertions integration
dandclark 2fc3616
Fix indentation/spacing. Use short list notation.
dandclark 697a6f1
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
dandclark a9eed9b
Use two separate scripts in example so that at least one will actuall…
dandclark 973ec71
Add module type to visited set.
dandclark 337124e
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
dandclark cf01c6d
Use two separate scripts in example so that at least one will actuall…
dandclark d954ad7
Add module type to visited set.
dandclark 5bc28f6
Add HostGetSupportedAssertions integration
dandclark 1b4da46
Fix indentation/spacing. Use short list notation.
dandclark eb8d82d
Merge branch 'dandclark/import-attributes-no-json' into dandclark/imp…
dandclark 45f6c6e
Fix up some issues from merge
dandclark 87eec91
Update visited set changes for json module type
dandclark fdc08f8
Clarify that memory cache mitigating violation of import assertions s…
dandclark a9f4d00
Merge branch 'dandclark/import-attributes-no-json' into dandclark/imp…
dandclark 30e27fb
Merge remote-tracking branch 'upstream/main' into dandclark/import-at…
dandclark 9ec7c7e
Add class='XXX' to note about the memory cache
dandclark 9690560
Merge branch 'dandclark/import-attributes-no-json' into dandclark/imp…
dandclark f5f9ec1
Merge branch 'main' into dandclark/import-attributes-no-json
dandclark be37963
Merge branch 'dandclark/import-attributes-no-json' into dandclark/imp…
dandclark ab21bd5
Merge branch 'main' into dandclark/import-attributes
dandclark aa104e0
Fix spacing
dandclark 64c523d
Delete duplicated example
dandclark 54498ba
Restore updated comments about CSS/JSON module script definition
dandclark 9de359a
Combine some paragraphs
dandclark d4f5bd0
Add missing closing tags
dandclark 43526c4
Use CreateDefaultExportSyntheticModule for CSS module scripts
dandclark 10af46b
Use not/or instead of neither/nor
dandclark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.