Skip to content

doesn't remove lodash import given it's still used in the example #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 14, 2017
Merged

doesn't remove lodash import given it's still used in the example #1411

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2700dc5
doesn't remove lodash import given it's still used
olistik Jul 11, 2017
fe3fdd1
places the import back in place
olistik Jul 11, 2017
997f67e
doc(guides): fix whitespace in asset-management.md
TheDutchCoder Jul 11, 2017
4f155ee
Merge branch 'master' into patch-1
skipjack Jul 13, 2017
2b67e03
Merge branch 'master' into patch-1
TheDutchCoder Jul 14, 2017
bd731d7
Merge branch 'master' into patch-1
skipjack Jul 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions content/guides/asset-management.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ __webpack.config.js__
__src/index.js__

``` diff
- import _ from 'lodash';
import _ from 'lodash';
- import './style.css';
- import Icon from './icon.png';
- import Data from './data.xml';
Expand All @@ -600,7 +600,7 @@ __src/index.js__
var element = document.createElement('div');
-
- // Lodash, now imported by this script
- element.innerHTML = _.join(['Hello', 'webpack'], ' ');
element.innerHTML = _.join(['Hello', 'webpack'], ' ');
- element.classList.add('hello');
-
- // Add the image to our existing div.
Expand All @@ -610,7 +610,6 @@ __src/index.js__
- element.appendChild(myIcon);
-
- console.log(Data);
+ element.innerHTML = _.join(['Hello', 'webpack'], ' ');

return element;
}
Expand Down