Remove LF, CRLF, CR from output to get a consistent [contenthash]

[peterhirn]

Plugin creates identical output files with different contenthash-values when input is LF vs CRLF.

I think the content-hash should be calculated based on the output?

[alexander-akait]

@peterhirn we already calculate contenthash on output, we need remove LF, CRLF, CR lines from output, for css it doesn't have mean, feel free to send a PR

[peterhirn]

Thank you for your response. I was looking at the output generate by optimize-css-assets-webpack-plugin, that's where I got the wrong assumption about the content-hash generation. I'll change the title.

[KingScooty]

I have a feeling i'm experiencing the same issue. We've got snapshots that keep failing due to changed CSS contenthashes, when the CSS rules in each file are exactly the same. What's weird is the hashes are the same when building on the same machine, but different when a new person clones the project down and does a build.

Suggests contenthashes are changing on a machine by machine basis :/

[alexander-akait]

@KingScooty yep, i think it is bug, anyway can you create minimum reproducible test repo to ensure problem in LF/CRLF and CR, thanks!

[alexander-akait]

Investigation (include other bundlers):

• webpack
• parcel
• rollup (using plugin)

All bundlers (list above) generate other hash (contenthash for webpack) if you add/remove spaces/newlines or you change LF, CRLF and CR to other value.

So it is normal what contenthash changes when you change line ending to other value.

Also i was wrong, it is not safe change line ending, it can potential break code. Also you usually use minimizer for production (for example cssnano) so you file(s) doesn't contain lines and contenthash should be same on difference computers. Using contenthash for dev purpose is not recommended (decrease compilation time).

If you still have difference contenthash on difference computers maybe some plugins (postcss or webpack) adding something new in source code based on your environment or your project use difference line ending styles (recommendation - put .editorconfig and use prettier or stylelint for catch problems with difference line ending in source code).

Anyway feel free to open new issue, if you still have difference contenthash on difference computers following the recommendations above.

[Lyrkan]

Anyway feel free to open new issue, if you still have difference contenthash on difference computers following the recommendations above.

@evilebottnawi I think the issue wasn't really related to LF/CRLF/CR, there is another problem leading to inconsistent [contenthash] since mini-css-extract-plugin@^0.4.4: #308

Since it basically gives a different hash depending on the root path (from what I understand) it is very likely to occur when building on different OS.

[alexander-akait]

@Lyrkan problem with source map, postcss generate absolute source map, so sources always have difference paths, known issue, we working on this

[redfox05]

We're also having this issue. Same hash is generated on one machine, but the content hash keeps changing when a different developer does a webpack build and nothing has changed in the content. Then it stays the same for that developer, but changes again when another developer does a build.

Any tips for working around this?

@evilebottnawi you mention that this is a known issue, do you have an open issue number we can track, as this one is closed, so I'm assuming the known issue is known by a different id?

[alexander-akait]

fixed in webpack@5, can't be fixed in webpack@4