Add jbfl unit tests #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webdevred
force-pushed
the
add_jbfl_unit_tests
branch
7 times, most recently
from
5219c14 to
3d87809
Compare
Initially, custom Show instances were designed to mirror the parser syntax (e.g., `.key`, `[3]`), which seemed intuitive and aligned with how patterns are written and parsed. However, this syntax turned out to be ambiguous during debugging. For example, `.5` could be interpreted as either ObjectKey "5" or ObjectIndex 5, making it harder to distinguish cases in tests. Switched to `deriving stock Show` for NodeSelector, NodePath, NodePatternSelector, and NodePattern to ensure clear, constructor-based output. Also removed a import (Data.Text) that became unused in NodePath.hs. This change prioritizes clarity and debuggability over parser-style aesthetics in internal representations.
Needed for parsing the AST files with expected out AST after parsing the jbfl and jbeam example files.
webdevred
force-pushed
the
add_jbfl_unit_tests
branch
5 times, most recently
from
597ca41 to
e93266b
Compare
- Introduced `dump-ast` executable to parse and pretty-print ASTs for JBFL and JBEAM files - Added manual `dump-ast` flag to control whether the executable is built - Configured cabal and package.yaml to build the executable only when the flag is enabled - Updated hie.yaml to support IDE tooling for the new executable - This executable is needed to generate AST files used in the tests being added in this branch - Allows generating Haskell AST representations from example input files without affecting main builds
- Consolidated AST dumping logic into `saveDump` function in dump_ast tool. - Updated .gitignore to exclude `cabal.project.local` and backup files. - Simplified `hie.yaml` by replacing multiple cradle paths with unified cabal components. - Minor formatting and clarity improvements in `stack.yaml`.
webdevred
force-pushed
the
add_jbfl_unit_tests
branch
from
e93266b to
e1eeb0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces focused unit tests for the
Parsing.DSLmodule and adds reusable parser test helpers. It also includes minor refactoring and enhancements in core modules to support better testability and correctness.Changes
New Tests
test/Parsing/DSLSpec.hs:PadDecimals,PadAmount) and boolean (NoComplexNewLine) types.shouldFailWith.test/Parsing/ParsingTestHelpers.hs:applyParserSpecto streamline and simplify parser test definitions.Note: Before merging, I will add positive and negative tests for node patterns, rules and rulesets.
Refactoring and Enhancements
These changes were necessary to implement the JBFL tests:
Formatting.Rules.hs:Eqinstance forSomeProperty.PropertyKeyto support equality comparisons in tests.lookupPropto requireEqfor consistency.Parsing.DSL.hs:keyParser→objectKeyParser).objectIndexParser.keyPropertyPairParserfor test usage.tools/dump_ast: