Skip to content

chore: BIP32HDNode - SwiftLint clean up #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JeneaVranceanu
Copy link
Collaborator

@JeneaVranceanu JeneaVranceanu commented Feb 5, 2023

Summary of Changes

Review only after #756 is merged

BIP32HDNode.swift - manual SwiftLint fixes.

Test Data or Screenshots

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@JeneaVranceanu JeneaVranceanu added the ready for review issue is resolved, a final review is needed before closing label Feb 5, 2023
@yaroslavyaroslav
Copy link
Collaborator

There's a conflict appeared @JeneaVranceanu

@cclauss
Copy link
Contributor

cclauss commented Feb 10, 2023

Can this pull request enable swiftlint in pre-commit or is there more work required before swiftlint can be enabled?

@JeneaVranceanu
Copy link
Collaborator Author

Can this pull request enable swiftlint in pre-commit or is there more work required before swiftlint can be enabled?

There is more work required before we can enable swiftlint in pre-commit. We are not even halfway there.
I'll do my best to post updates regularly. Maybe will be able to eliminate all issues this week but it will likely be a combination of real fixes + // swiftlint:disable ... in places where we need heavy refactoring.

@JeneaVranceanu
Copy link
Collaborator Author

@yaroslavyaroslav @janndriessen Fixed conflicts.

@JeneaVranceanu JeneaVranceanu merged commit 92db962 into web3swift-team:develop Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review issue is resolved, a final review is needed before closing refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants