EthereumContractTest removed swiftLint errors and warnings

[albertopeam]

removed:

1. error: Force Cast Violation
2. error: Force Try Violation
3. warning: Force Unwrapping Violation
4. warning: Indentation Width Violation

[albertopeam]

It seems a good idea(at least for me) to start cleaning up tests from swiftLint warns and errors, small PRs that are easy to read.
what do you think?

[janndriessen]

It seems a good idea(at least for me) to start cleaning up tests from swiftLint warns and errors, small PRs that are easy to read. what do you think?

This is a good idea! I think it would be best though to wait until #685 #683 #673 are all merged - as otherwise this will just lead to lots of merge conflicts.

[yaroslavyaroslav]

@albertopeam just saying, that by far we've discussed such, though it was a long time ago, we doesn't apply such sever rules for tests as for the library code itself, for example there was force try and force unwrap allowing as long as it passed ci/cd pipeline.

This is not that I'm against such sever rules for tests I'm actually up to, just back there there was a very few folks who contribute here constantly besides me, drastically in contrary as it is now, but my point is that it worth to at least discuss and vote for all such point which in whole would become contribution guidelines actually.

[pharms-eth]

It seems a good idea(at least for me) to start cleaning up tests from swiftLint warns and errors, small PRs that are easy to read. what do you think?

This is a good idea! I think it would be best though to wait until #685 #683 #673 are all merged - as otherwise this will just lead to lots of merge conflicts.

in addition to:
#689
#687
thank you

[albertopeam]

@albertopeam just saying, that by far we've discussed such, though it was a long time ago, we doesn't apply such sever rules for tests as for the library code itself, for example there was force try and force unwrap allowing as long as it passed ci/cd pipeline.

Sure, I am here to listen and learn. If you want to discuss the rules of swiftlint I am in :)

[albertopeam]

my point of view is to avoid using ! in code and also in tests. Reason:
I can understand that maybe is not so important in tests but the thing is that a ! will crash the test suite, I think the proper way is to not crash to fail elegantly. To do it is kind of easy to replace force unwrap !with XCTUnwrap.
Said that, I can do it progresively file by file in small PRs that can be quickly merged if you think my point is valid or better than now :)

[janndriessen]

LGTM!