Add tests for EIP1559 transactions on Mainnet and Goerli #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaroslavyaroslav
approved these changes
Nov 1, 2022
|
Also I'm dunno if this is covering cases where we could fail with tx sending on signing it as Raw one? |
Most projects I worked on so far always used unsigned tx's to verify via |
|
You're right, actually my point it's that I'm not sure that it's not buggy so far) |
yaroslavyaroslav
approved these changes
Nov 1, 2022
|
Anyway this could be made with additional PR. Thank you did tour support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for EIP1559 transactions on Mainnet and Goerli - to verify that transaction configurations work when sending ether.
Discussed on Discord.