erc20 transfer function would create another transaction that differ from erc20's transaction and then lost important info

[powfulhong]

What happened?

    let contractEthreumAddress = EthereumAddress(contractAddress)!
    let erc20 = ERC20(web3: web3, provider: web3.provider, address: contractEthreumAddress)
    guard let writeOP = try? await erc20.transfer(from: EthereumAddress(fromAddress)!, to: EthereumAddress(toAddress)!, amount: amount) else {
        return nil
    }
    
    var transaction = writeOP.transaction
    /// lose, need to add back
    transaction.from = erc20.transaction.from
    transaction.to = contractEthreumAddress
    transaction.callOnBlock = .latest

writeOP.transaction is different to erc20.transaction. They are 2 different instances. And writeOP.transaction lose the from & to & callOnBlock information.
if I donot add the last three codes, when I call web3.eth.send(raw)，it just returns nil.

Library version

3.06

[yaroslavyaroslav]

writeOP.transaction is different to erc20.transaction. They are 2 different instances.

That's definitely the bug. It's kinda easy to be fixed one, since it appears that ERC20.tx property never assigns to a Contract.tx property which they should.

I've provided a quick fix for it. So I think this given case would be fixed within a week or so.

Thanks for point this out.

[yaroslavyaroslav]

Anyway, please be aware, that the fix fixes only the one given case of the error that are all ERC* types affected. Thus more general #712 issue has been created.

[powfulhong]

Thank you for your timely reply.