IndexedDB: Add test for commit order of empty transactions #3154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewers for this pull request are: @velmont, @chunywang, @dumbmatter, @inexorabletash, @yunxiaoxie, @zhaozihao, and @zqzhang. |
|
Critic review: https://critic.hoppipolla.co.uk/r/6609 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
@bevis-tseng - can you review this? |
| tx3.oncomplete = t.step_func(() => saw('tx3.oncomplete')); | ||
|
|
||
| var rq2 = store.put('b', 2); | ||
| rq2.onsuccess = () => t.step_func(saw('rq2.onsuccess')); |
There was a problem hiding this comment.
LGTM except line#84 in transaction-lifetime-empty.html.
Is it intended? IMO, It's more proper to be:
rq2.onsuccess = t.step_func(() => saw('rq2.onsuccess'));
There was a problem hiding this comment.
Whoops, thanks. Will fix.
ivanzr
pushed a commit
to ivanzr/web-platform-tests
that referenced
this pull request
Jun 29, 2016
…orm-tests#3154) Tracked by w3c/IndexedDB#77 Ensure that a transaction with no requests filed against it still completes in the same order as a transaction with requests (i.e. after previous readwrite transactions with overlapping scope).
ddorwin
pushed a commit
to ddorwin/web-platform-tests
that referenced
this pull request
Sep 13, 2016
…orm-tests#3154) Tracked by w3c/IndexedDB#77 Ensure that a transaction with no requests filed against it still completes in the same order as a transaction with requests (i.e. after previous readwrite transactions with overlapping scope).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in w3c/IndexedDB#77 it is expected that "empty" transactions (no requests filed) still complete with the same ordering requirements as transactions with requests. Specifically, if transaction A is created after a read/write transaction B with overlapping scope, A should complete after B completes.