-
-
Notifications
You must be signed in to change notification settings - Fork 667
perf: replace string-cache with bucket-level version #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
f1188c1
to
2a87cde
Compare
!bench |
Benchmark Results
|
2a87cde
to
3669415
Compare
The Vec version is flawed, let's try the slightly slower but correct linked-list version. |
!bench |
Benchmark Results
|
!snapshot |
0.0.0-3669415e-20230217092725 |
See servo/string-cache#268
For testing, I ran
rspack build
for 100 iterations for both mgp and apaas, no errors encountered.Perf gain: