This repository was archived by the owner on Aug 19, 2022. It is now read-only.
Upgrade to tower-lsp 0.13.0 #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changes in release v0.13.0 for details!
Note: since all the
Client
methods have been changed toasync fn
, as described in ebkalderon/tower-lsp#180 (comment), I identified a compile error caused bytree-sitter
interacting poorly with async/await andSend
futures:This is fixed by wrapping the
node
variable in a lexical scope so that the variable gets dropped early before thesession.client.publish_diagnostics(...).await;
call occurs. This solution was inspired by rust-lang/rust#64856.Let me know what you think, @darinmorrison! Does this look good to you? Any suggestions?