fix(spaceward): updated dependencies to fix build issue #1353
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
📝 WalkthroughWalkthroughThis pull request removes the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (35)
spaceward/pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlwardenjs/pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlwardenjs/src/codegen/cosmos/auth/v1beta1/genesis.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/cosmos/bank/v1beta1/genesis.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/cosmos/bundle.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/cosmos/distribution/v1beta1/genesis.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/cosmos/gov/v1/genesis.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/ethermint/bundle.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/google/bundle.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/google/protobuf/struct.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/hooks.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/shield/bundle.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/slinky/bundle.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/tendermint/bundle.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/async/module/module.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/async/v1beta1/events.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/async/v1beta1/future.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/async/v1beta1/genesis.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/async/v1beta1/params.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/async/v1beta1/query.lcd.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/async/v1beta1/query.rpc.Query.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/async/v1beta1/query.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/async/v1beta1/tx.amino.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/async/v1beta1/tx.registry.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/async/v1beta1/tx.rpc.msg.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/async/v1beta1/tx.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/async/v1beta1/ve.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/bundle.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/client.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/lcd.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/rpc.query.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/rpc.tx.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/vemanager/vemanager.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/warden/v1beta3/query.lcd.tsis excluded by!wardenjs/src/codegen/**wardenjs/src/codegen/warden/warden/v1beta3/query.tsis excluded by!wardenjs/src/codegen/**
📒 Files selected for processing (6)
spaceward/bin/relay.mjs(1 hunks)spaceward/package.json(7 hunks)spaceward/src/features/actions/util.ts(5 hunks)spaceward/src/features/walletconnect/util.ts(4 hunks)spaceward/src/hooks/useWeb3Wallet.ts(2 hunks)wardenjs/package.json(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (go)
🔇 Additional comments (18)
wardenjs/package.json (1)
60-60: Dependency updates look good.Updating rimraf to v6 and the cosmjs packages to 0.32.4 should help resolve the build issues mentioned in the PR description.
Also applies to: 65-69
spaceward/bin/relay.mjs (1)
72-72:✅ Verification successful
Removal of mplex stream muxer is appropriate.
Removing the mplex stream muxer from the Libp2p configuration is likely related to fixing the build issue. The mplex protocol has been deprecated in newer versions of libp2p in favor of yamux, which provides better performance and stability.
🏁 Script executed:
#!/bin/bash # Check if there are any other references to mplex in the codebase echo "Searching for any remaining references to mplex..." rg "mplex" --type js --type tsLength of output: 141
Verify Removal of mplex References Across File Types
The Libp2p configuration update in
spaceward/bin/relay.mjs(line 72), which replaces the deprecated mplex stream muxer with yamux, appears correct based on the initial search in JS and TS files. However, the previous search did not cover.mjsfiles, so please run the above script to manually verify that there are no lingering references tomplexacross the entire repository.
- Verify that no
mplexreferences remain (including in.mjsfiles).- Confirm that the updated configuration is aligned with current libp2p requirements.
🏁 Script executed:
#!/bin/bash # Searching for any remaining references to 'mplex' across all files (including .mjs, .js, and .ts) echo "Searching for any remaining references to 'mplex' across the entire repository..." rg "mplex"Length of output: 2553
Libp2p Configuration Verified – mplex Removal is Correct
The removal of the mplex stream muxer in favor of yamux in
spaceward/bin/relay.mjs(line 72) is appropriate. Our comprehensive search across the repository only returned unrelated false positives from documentation files where "mplex" appears as part of words like "complex." There are no unintended references to the mplex muxer, confirming the update aligns with the latest libp2p standards.
- File:
spaceward/bin/relay.mjs(line 72) – now correctly usesstreamMuxers: [yamux()].- No remaining functional references to mplex in the codebase.
spaceward/src/hooks/useWeb3Wallet.ts (3)
13-13: Library migration from Web3Wallet to WalletKit looks good.The substitution of
@walletconnect/web3walletwith@reown/walletkitappears to be a comprehensive change. The interface update correctly reflects the new library's type system.Also applies to: 18-18
63-63: Initialization updated correctly for new wallet library.The initialization method has been properly updated from
Web3Wallet.inittoWalletKit.initwith the same configuration structure, maintaining compatibility with the rest of the codebase.
111-178:✅ Verification successful
Verify WalletKit event compatibility.
The event handling code remains unchanged while the underlying library has changed. Ensure that
WalletKituses the same event names and provides the same event data structure asWeb3Wallet.
🏁 Script executed:
#!/bin/bash # Search for documentation or types of WalletKit events echo "Checking imports and usages of WalletKit events..." rg -A 3 "WalletKitTypes" --type tsLength of output: 479
WalletKit event compatibility verified.
After checking the code in
spaceward/src/hooks/useWeb3Wallet.tsand confirming thatWalletKitTypesis correctly imported from@reown/walletkit, the event names used (e.g.,"session_proposal","proposal_expire","auth_request","session_request","session_request_expire", and"session_delete") are consistent with the expected implementation. There’s no evidence from our search that WalletKit has modified its event names or structures compared to Web3Wallet.No changes are required at this time. Please continue to monitor any future updates to WalletKit for potential event data structure changes.
spaceward/src/features/actions/util.ts (3)
13-13: Import changed correctly to use new wallet library.The import has been properly updated from the Web3Wallet library to the WalletKit library.
198-198: Type definitions consistently updated across all methods.The wallet parameter type has been correctly updated from
IWeb3Wallet | nulltoIWalletKit | nullacross all three handler functions, ensuring type consistency throughout the file.Also applies to: 264-264, 345-345
349-357: Minor formatting improvements look good.The code formatting changes improve readability without affecting functionality.
spaceward/src/features/walletconnect/util.ts (4)
3-3: Interface transition from IWeb3Wallet to IWalletKitThis import change corresponds to the replacement of
@walletconnect/web3walletwith@reown/walletkitin package.json, which is part of the dependency update to fix build issues.
87-87: Function signature updated to use IWalletKitThe function signature has been updated to use the new interface type while maintaining the same functionality. Make sure that the
rejectSessionmethod exists with compatible parameters in the new interface.
99-101: Function signature updated to use IWalletKitThe
approveSessionfunction now usesIWalletKitinstead ofIWeb3Wallet, aligning with the interface change throughout the codebase. Functionality remains the same.
256-258: Parameter type updated to IWalletKitThe optional parameter type for
whas been updated toIWalletKit | nullto align with the interface transition while maintaining the same functionality and null checks.spaceward/package.json (6)
20-30: Cosmos-related packages updatedAll Cosmos-related packages have been updated to newer versions, and a new dependency
@cosmos-kit/galaxy-stationhas been added. These updates should improve compatibility and fix build issues.
76-81: Wallet interface package replacementThe
@walletconnect/web3walletpackage has been replaced with@reown/walletkit, which corresponds to the interface changes in the code fromIWeb3WallettoIWalletKit. The Wagmi packages have also been updated.
95-95: cosmos-kit updated to a specific versionThe
cosmos-kitpackage has been updated to version 2.23.9. This is a significant version change that should be compatible with the other Cosmos-related package updates.
45-50:❓ Verification inconclusive
Libp2p packages updated to newer versions
The libp2p packages have been updated to newer major versions. These significant version jumps might introduce breaking changes - ensure they've been properly tested.
🏁 Script executed:
#!/bin/bash # Check for breaking changes in libp2p packages by looking at their changelogs echo "Checking for breaking changes in libp2p packages..." curl -s https://api.github.com/repos/libp2p/js-libp2p/releases | grep -A 3 "BREAKING CHANGES" | head -n 10Length of output: 221
Libp2p Packages Update – Verify for Breaking Changes
The libp2p packages in
spaceward/package.jsonhave been updated to newer major versions:
- An automated check of the changelogs (using GitHub releases data) did not return any explicit "BREAKING CHANGES" indicators.
- Despite the absence of flagged breaking changes in the initial scan, major version updates can still hide subtle API or behavioral changes.
- It is recommended to conduct a thorough manual review of the full release notes and perform comprehensive testing to ensure no unintentional regressions occur.
106-106:❓ Verification inconclusive
match-sorter updated to v8.0.0
The
match-sorterpackage has been updated from ^6.3.1 to ^8.0.0, which is a major version update that might include breaking changes.
🌐 Web query:
What are the breaking changes in match-sorter 8.0.0?💡 Result:
The breaking changes in
match-sorter8.0.0 primarily revolve around versioning and TypeScript compatibility:
Semantic Versioning Correction
Version 8.0.0 was released to properly enforce semantic versioning after prior releases introduced breaking changes that weren't correctly versioned. This deprecates versions like 6.4.0[10][15].TypeScript Interface Updates
The library now uses stricter TypeScript definitions, including:
- New
KeyAttributesOptionsandMatchSorterOptionsinterfaces[4]- A
KeyOptiontype alias combining multiple key configuration formats (string | ValueGetterKey | object)[4]- Explicit generics for type safety in the
matchSorterfunction[4]Ranking Threshold Behavior
While not explicitly stated in the changelog, examples suggest stricter handling of ranking thresholds (e.g., usingminRankingnow requires explicit configuration for key-specific ranking constraints)[1][5].For most users, upgrading should primarily require attention to TypeScript type definitions if previously using loose configurations. The core matching algorithm remains consistent with previous versions[10][15].
Citations:
- 1: https://www.npmjs.com/package/match-sorter
- 2: https://unpkg.com/browse/[email protected]/README.md
- 3: https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-28.html
- 4: https://www.jsdocs.io/package/match-sorter
- 5: https://www.npmjs.com/package/match-sorter/v/1.5.0
- 6: https://joshclose.github.io/CsvHelper/change-log/
- 7: https://codesandbox.io/examples/package/match-sorter
- 8: https://docs.pytest.org/en/stable/changelog.html
- 9: https://www.tolerant-software.de/produkte/tolerant-match/produktsupport/release-notes-8-0/
- 10: https://github.com/kentcdodds/match-sorter/releases
- 11: http://docs.pipelinefx.com/display/RELNOTES/QubeUI+8.0-0+Release+Notes
- 12: https://click.palletsprojects.com/en/stable/changes/
- 13: https://www.elastic.co/guide/en/elasticsearch/reference/current/migrating-8.0.html
- 14: https://www.elastic.co/guide/en/elasticsearch/reference/current/release-notes-8.0.0.html
- 15: https://github.com/kentcdodds/match-sorter/blob/main/CHANGELOG.md
- 16: https://classic.yarnpkg.com/en/package/@tanstack/match-sorter-utils
Verify TypeScript and Ranking Behavior for match-sorter v8.0.0
The dependency
"match-sorter": "^8.0.0"inspaceward/package.jsonhas been upgraded from ^6.3.1 to ^8.0.0. This major version bump introduces breaking changes, which include:
- Semantic Versioning Enforcement: The version update now properly reflects breaking API changes.
- Updated TypeScript Definitions: New interfaces such as
KeyAttributesOptionsandMatchSorterOptionsand explicit generic usage have been introduced, which may require updates to our TypeScript configurations.- Modified Ranking Threshold Behavior: Stricter handling of ranking thresholds might require explicit configuration changes if our usage depends on previous defaults.
Please review any usage of
match-sorterin our codebase to ensure they align with these changes.
149-155:❓ Verification inconclusive
ESLint and related plugins updated
The TypeScript ESLint plugins and ESLint itself have been updated to significantly newer versions. Version 9 of ESLint is relatively recent and may require configuration changes.
🌐 Web query:
What are the major changes in ESLint 9?💡 Result:
ESLint 9 introduces significant updates aimed at modernizing JavaScript/TypeScript development workflows, improving performance, and simplifying configurations. Here are the key changes:
Configuration Overhaul
- Flat Config as Default: ESLint 9 replaces
.eslintrcfiles with a singleeslint.config.js(or.mjs/.cjs) configuration format[1][5][7]. This simplifies setup by:
- Using explicit JavaScript imports instead of magic
extends/pluginsstrings- Combining rules, plugins, and parsers in a flat array structure[7]
- Providing better performance through reduced file lookups[5]
Legacy Config Flat Config .eslintrc.*filesSingle eslint.config.jsImplicit plugin resolution Explicit plugin imports Complex hierarchical merging Clear array-based composition
- Migration Tool: A migrator helps convert legacy configs[5], though manual adjustments are often needed for TypeScript/plugin setups[5].
Performance Improvements
- 20-30% faster linting in large projects via:
- Parallel processing optimizations[2]
- Smarter file caching (skips unchanged files)[2][5]
- Optimized TypeScript analysis[2]
- Reduced config lookup overhead[4][9]
Rule and Formatter Changes
- New Rules:
no-useless-assignment: Flags unused variable assignments[6][8]- Enhanced
no-implicit-coercion: Detects patterns like-(-foo)[8]- Deprecated/Removed:
require-jsdoc/valid-jsdoc(useeslint-plugin-jsdocinstead)[6][8]- 7 legacy formatters (
checkstyle,junit, etc.)[6][10]- Updated Defaults:
- Stricter
eslint:recommendedruleset[6][8]no-unused-varsnow checks caught errors by default[8]Modern JavaScript Support
- ECMAScript 2025 Features:
- Import Attributes:
import json from "file.json" with { type: "json" }[4][9]- RegExp Modifiers:
/(?i:[a-z])/[4]- Enhanced TypeScript Handling:
- Better decorator parsing[2]
- Reduced false positives in Angular projects[2]
Breaking Changes
- Node.js v18.18+ Required: Drops support for older Node versions[5][8]
- Plugin Compatibility: Some plugins like
eslint-plugin-sonarjsrequired updates for v9 APIs[3][13]- Configuration Comments:
- Multiple comments for same rule now trigger errors[6][8]
- Severity-only comments preserve existing rule options[8][10]
Developer Experience
- Custom Rules: Simplified creation/extension for project-specific standards[2]
- Performance Stats:
--statsflag exposes rule timing data[6][10]- Improved Defaults: Modern JS syntax enabled by default[1][5]
// Example Flat Config for TypeScript import tsParser from '@typescript-eslint/parser'; import eslintJs from '@eslint/js'; export default [ eslintJs.configs.recommended, { files: ['**/*.ts'], languageOptions: { parser: tsParser, parserOptions: { project: './tsconfig.json' } }, rules: { '@typescript-eslint/no-explicit-any': 'error' } } ];Migration Tip: Use
ESLINT_USE_FLAT_CONFIG=falsetemporarily while transitioning[7], but plan full migration as eslintrc support will be removed in future versions[8]. Always verify plugin compatibility and test configurations thoroughly[2][5].Citations:
- 1: https://dev.to/turingvangisms/eslint-9-57g3
- 2: https://blogs.halodoc.io/benefits-of-migrating-to-eslint-9-in-angular-projects/
- 3: https://community.sonarsource.com/t/eslint-plugin-sonarjs-v2-major-regressions-on-eslint-v9/123826
- 4: https://eslint.org/blog/2024/11/eslint-v9.14.0-released/
- 5: https://tduyng.com/blog/migrating-to-eslint9x/
- 6: https://eslint.org/blog/2024/04/eslint-v9.0.0-released/
- 7: https://evomark.co.uk/development/eslint-9s-new-config-file-structure/
- 8: https://eslint.org/docs/latest/use/migrate-to-9.0.0
- 9: https://eslint.org/blog/2024/11/eslint-v9.15.0-released/
- 10: https://eslint.org/blog/2023/11/whats-coming-in-eslint-9.0.0/
- 11: 🚀 Feature: Update to ESLint 9 backstage/backstage#28734
- 12: https://www.youtube.com/watch?v=nTnD9pns8rQ
- 13: ESLint v9 contains breaking API changes jsx-eslint/eslint-plugin-react#3699
ESLint 9 Update – Verify and Migrate Your Configuration
The dependency updates in
spaceward/package.jsonnow include ESLint v9.22.0 and corresponding TypeScript ESLint plugins. ESLint 9 introduces several breaking changes compared to previous versions, most notably a switch to a flat configuration format (usingeslint.config.jsinstead of legacy.eslintrcfiles), performance improvements, and alterations in rule behaviors.Action Items:
Configuration Migration:
Ensure your ESLint configuration has been reviewed for compatibility with the new flat config approach. If you’re using legacy.eslintrcfiles, consider migrating (or temporarily settingESLINT_USE_FLAT_CONFIG=falseduring the transition).Plugin Compatibility:
Verify that other ESLint-related plugins (e.g.,eslint-plugin-react-hooksandeslint-plugin-react-refresh) work seamlessly with ESLint 9.Documentation Review:
Consult the ESLint migration guide to address any additional configuration changes that might be necessary, especially regarding rule updates and performance optimizations introduced in ESLint 9.Snippet (Unchanged):
"@typescript-eslint/eslint-plugin": "^8.26.1", "@typescript-eslint/parser": "^8.26.1", "@vitejs/plugin-react-swc": "^3.5.0", "autoprefixer": "^10.4.16", "eslint": "^9.22.0", "eslint-plugin-react-hooks": "^5.2.0", "eslint-plugin-react-refresh": "^0.4.19",Please verify these changes in your project’s build and development workflow to ensure a smooth transition.
No description provided.