Skip to content

docs: official blog plugin and theme #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2020
Merged

docs: official blog plugin and theme #2149

merged 1 commit into from
Jan 29, 2020

Conversation

billyyyyy3320
Copy link
Collaborator

Summary

The WIP status has just been removed.

As they are official plugin and theme, It probably should be mentioned in documentation. The content is distilled from README.md, if you have any better idea to introduce them, please leave your comment.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Collaborator

@kefranabg kefranabg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kefranabg
Copy link
Collaborator

Shouldn't we add the blog plugin in the plugin section?

@billyyyyy3320
Copy link
Collaborator Author

Shouldn't we add the blog plugin in the plugin section?

I feel like the Plugin section focus on how to use and write a plugin, so I list them in the Official Plugins section. Besides, I found that it's been mentioned in examples.

@kefranabg
Copy link
Collaborator

Is it ready to merge?

@billyyyyy3320
Copy link
Collaborator Author

I think so

@billyyyyy3320 billyyyyy3320 merged commit aa0dd20 into master Jan 29, 2020
@billyyyyy3320 billyyyyy3320 deleted the doc/blog branch January 31, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants