Skip to content
This repository was archived by the owner on Dec 26, 2018. It is now read-only.

Fix: invalid warning about babel #183

Merged
merged 1 commit into from
Mar 9, 2017

Conversation

mysticatea
Copy link
Member

In the following code and no .babelrc, vueify prints an error message wrongly based on unused default options. This PR fixes the problem.

browserify(entryFile)
    .transform("vueify", { babel: { /* some settings */ } })
    .bundle()
    .pipe(output)
You are trying to use "babel". babel-preset-es2015 and babel-plugin-transform-runtime is missing.

To install run:
npm install --save-dev babel-preset-es2015 babel-plugin-transform-runtime

^^^ You are seeing this because you are using Vueify's default babel configuration. You can override this with .babelrc or the babel option in vue.config.js.

This PR related to the line /lib/compilers/babel.js#L47.

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
LGTM!

/ping @yyx990803 @zigomir
What do you think about it?

@yyx990803 yyx990803 merged commit 6992fc7 into vuejs:master Mar 9, 2017
@mysticatea mysticatea deleted the fix-invalid-babel-warning branch March 9, 2017 02:42
@mysticatea
Copy link
Member Author

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants