Skip to content
This repository was archived by the owner on Dec 26, 2018. It is now read-only.

Don't make .babelrc a requirement. #103

Merged
merged 2 commits into from
Jun 30, 2016
Merged

Don't make .babelrc a requirement. #103

merged 2 commits into from
Jun 30, 2016

Conversation

zigomir
Copy link
Contributor

@zigomir zigomir commented Jun 24, 2016

If you don't have a .babelrc file in your project you still get babel warning: "You are trying to use "babel". babel-preset-es2015, babel-runtime and babel-plugin-transform-runtime are missing."

If you don't have a .babelrc file in your project you still get babel warning: "You are trying to use "babel". babel-preset-es2015, babel-runtime and babel-plugin-transform-runtime are missing."
@yyx990803
Copy link
Member

This is working as intended - not using a .babelrc implies you want to use vueify's default babel configuration, which requires these plugins. Otherwise vueify wouldn't know what babel options to use.

@zigomir
Copy link
Contributor Author

zigomir commented Jun 24, 2016

Hmm, I see. But how can you then use vueify 9+ without babel ... sure you don't want to have .babelrc file then.

@zigomir
Copy link
Contributor Author

zigomir commented Jun 29, 2016

@yyx990803 so what's bothering me here is that I need to have an empty .babelrc in a project where I don't use babel at all. Example template: https://github.com/zigomir/vue-simple-template/tree/simplify/template

My fix shouldn't break anything imo. It's just babel options check "lazily", and not up front when compilers/index.js gets required.

I added a commit where only if (babelOptions === defaultBabelOptions) {is moved inside exported function.

Does this make sense?

@yyx990803 yyx990803 merged commit cda407d into vuejs:next Jun 30, 2016
@zigomir zigomir deleted the projects-without-babelrc branch June 30, 2016 04:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants