Skip to content

typescript types don't allow multi-root functional components #8191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zevdg opened this issue May 15, 2018 · 0 comments
Closed

typescript types don't allow multi-root functional components #8191

zevdg opened this issue May 15, 2018 · 0 comments
Labels
has PR typescript

Comments

@zevdg
Copy link
Contributor

zevdg commented May 15, 2018

Version

2.5.16

Reproduction link

https://github.com/zevdg/vue-typescript-multi-root-component

Steps to reproduce

npm run serve

What is expected?

there shouldn't be errors

What is actually happening?

The page runs and works as expected, but the build shows type errors because the type definitions specify that a single VNode is always returned from functional componnts' render functions.

The fix for this is trivial. I've already fixed it locally, and I'll make a pull request.
@zevdg zevdg changed the title javascript types don't allow multi-root functional components typescript types don't allow multi-root functional components May 15, 2018
@zevdg zevdg mentioned this issue May 15, 2018
Merged
13 tasks
zevdg added a commit to zevdg/vue that referenced this issue May 16, 2018
@zevdg
types: allow functional components to return multiple VNodes
699f44d 
close vuejs#8191
@sgf sgf mentioned this issue Jan 19, 2019
Closed
f2009 pushed a commit to f2009/vue that referenced this issue Jan 25, 2019
@zevdg
types: allow functional components to return multiple VNodes (vuejs#8192
d1d8a7f 
)

close vuejs#8191
aJean pushed a commit to aJean/vue that referenced this issue Aug 19, 2020
@zevdg @aJean
types: allow functional components to return multiple VNodes (vuejs#8192
4b15e05 
)

close vuejs#8191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has PR typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zevdg @HerringtonDarkholme @haoqunjiang