data should be a function #812
Conversation
|
WTH do those tests fail now? confused ... |
| }) | ||
| wrapper.vm.test = 'some value' |
There was a problem hiding this comment.
@eddyerburgh I had to remove the mocks: { test: 'some value'} and replace it with this, otherwise the test woudl fail.
I suspect that this is because you can't actually mock properties for proxied data properties, but that didn't fail before because the data: { test: '' } itself failed?
Did my change break the intended goal of the test?
There was a problem hiding this comment.
This test is the first one written for localVue, and itcould be rewritten. The intent is to check that VTU mounts using the localVue constructor, so a better test would create a localVue constructor with createLocalVue, add a property to the localVue prototype, and mount a component that relies on that property existing.
Would you be able to rewrite it?
There was a problem hiding this comment.
might take a few days until I really have the time :/
|
Okay now I'm double-confused, the tests passed locally after d8101dc on CircleCI it breaks with a new error ... |
|
Thanks for this Thorsten , I've fixed this in #835 :) |
|
Yeah sorry, didn't have/make the time for this :/ |
closes #797