Skip to content

Add french Version #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 24, 2021
Merged

Add french Version #1837

merged 10 commits into from
Sep 24, 2021

Conversation

phrobinet
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:
    Here is my French version of the documentation.

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Hello, 

Here is my French version of the documentation.
Do not hesitate to make a return if you want modifications.

Have a nice day
Philippe

@lmiller1990
Copy link
Member

Wow, amazing! I will ping someone who knows French to give this a quick 👀

@@ -0,0 +1,4 @@
# Components

Vue Test Utils comprend des composants utilitaires que vous pouvez utiliser pour avoir des composants stubs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Vue Test Utils comprend des composants utilitaires que vous pouvez utiliser pour avoir des composants stubs
Vue Test Utils comprend des composants utilitaires que vous pouvez utiliser pour avoir des composants de remplacement (stubs).

Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phrobinet Thanks for your contribution!
I spotted a few typos.

Note: I'm not a huge fan of "affirmation" and "affirmer" (for "assertion" and "assert" in English I guess). I would use "vérification" and "vérifier".


### Couverture du code

Jest peut être utilisé pour générer des rapports de couverture dans plusieur formats. Voici un exemple simple pour commencer :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plusieurs

@phrobinet
Copy link
Contributor Author

@phrobinet Thanks for your contribution!
I spotted a few typos.

Note: I'm not a huge fan of "affirmation" and "affirmer" (for "assertion" and "assert" in English I guess). I would use "vérification" and "vérifier".

I'm not a fan of this word either but I couldn't find the right one and "verification" is much better, thanks

@lmiller1990
Copy link
Member

We can merge once we figure out why Netlify is failing 🤔

@lmiller1990
Copy link
Member

I see. We need to configure Vuepress to support a new translation. In this file: https://github.com/vuejs/vue-test-utils/blob/dev/docs/.vuepress/config.js

Are you able to do that @phrobinet, or if you don't have time, we can look for someone else to do it (or I can look into it, quite busy fixing 100+ other issues, though.

@phrobinet
Copy link
Contributor Author

configure.md
This is a configuration of the configure file so that it supports a new translation. Tell me if I need to make any changes to this file?

@lmiller1990
Copy link
Member

lmiller1990 commented Jul 7, 2021

I have no idea how it works, we will just need to play around with it. I'll give it a try now. yarn vuepress build fails - need to make it not fail.

@lmiller1990
Copy link
Member

Fixed some problems but still getting

wait Rendering static HTML...
[vuepress] No matching page found for sidebar item "/fr/api/components/"
[vuepress] No matching page found for sidebar item "/fr/api/components/"
[vuepress] No matching page found for sidebar item "/fr/api/components/"
[Vue warn]: Error in render: "TypeError: Cannot read property 'match' of undefined"

found in

--->





[vuepress] No matching page found for sidebar item "/fr/api/components/"
[vuepress] No matching page found for sidebar item "/fr/api/components/"
[vuepress] No matching page found for sidebar item "/fr/api/components/"
[Vue warn]: Error in render: "TypeError: Cannot read property 'match' of undefined"

I don't know why! 🤔

@phrobinet
Copy link
Contributor Author

Sorry to answer you so late but I'm back from holiday.

But then I don't understand what is going on 🤨.
This is the same configuration I use in my vue press projects and it's the same configuration as for the other languages.
I don't see what I've missed on this configuration.
Maybe you know someone who could answer this question?

@phrobinet
Copy link
Contributor Author

Hello,
I have understood where the problem with the sidebar was and I have just corrected it. And by the same occasion, I modified two pages (README) which are displayed badly in the French version
Normally it should work

@lmiller1990
Copy link
Member

Nice job! Just need to run prettier so CI can build, and we can merge. Thanks!

@lmiller1990
Copy link
Member

Merged!! Netlify should auto deploy.

@lmiller1990 lmiller1990 merged commit 60a3438 into vuejs:dev Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants