Skip to content

Emit api #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 18, 2017
Merged

Emit api #181

merged 10 commits into from
Nov 18, 2017

Conversation

lmiller1990
Copy link
Member

Add an alternative syntax for wrapper.emitted().

Also updated docs to include new syntax (ja and en).

@lmiller1990
Copy link
Member Author

lmiller1990 commented Nov 17, 2017

In response to #157 . It turned out adding the different syntax was trivial and I was overthinking it.

@eddyerburgh , I'm sure I need to add something for Typescript types somewhere for this. I'm sure you have some feedback or change requests. Please let me know!

Also perhaps @kazupon will check the Japanese translation.

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Translation 🌐

@lmiller1990
Copy link
Member Author

Thanks @kazupon .

Also for some reason createLocalVue Router should work properly with local Vue was failing locally, but it passes on the CI. Eh.

@eddyerburgh
Copy link
Member

Are you able to add types? They're in the types/index.d.ts https://github.com/vuejs/vue-test-utils/blob/dev/types/index.d.ts

I can help you if you're stuck 😄

@lmiller1990
Copy link
Member Author

I tried to add the types. I think it is just one type, the new optional event string. I haven't used typescript before, is it a big game changer? Should I be?

Let me know if I should change anything else, @eddyerburgh .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants