-
Notifications
You must be signed in to change notification settings - Fork 667
Emit api #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit api #181
Conversation
In response to #157 . It turned out adding the different syntax was trivial and I was overthinking it. @eddyerburgh , I'm sure I need to add something for Typescript types somewhere for this. I'm sure you have some feedback or change requests. Please let me know! Also perhaps @kazupon will check the Japanese translation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Translation 🌐
Thanks @kazupon . Also for some reason |
Are you able to add types? They're in the types/index.d.ts https://github.com/vuejs/vue-test-utils/blob/dev/types/index.d.ts I can help you if you're stuck 😄 |
I tried to add the types. I think it is just one type, the new optional event string. I haven't used typescript before, is it a big game changer? Should I be? Let me know if I should change anything else, @eddyerburgh . |
Add an alternative syntax for
wrapper.emitted()
.Also updated docs to include new syntax (ja and en).