Fix popstate handler sending wrong parameters to scrollBehavior #1479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the
scrollBehavior
callback received the same route object asto
andfrom
parameters when users click the browser's back/forward button.Then I followed the call stacks and found that there was a one line bug at
history/html5.js
Actually the
this.current
is changed before the callback be called.Since it's a bit hard to provide a history-mode demo in codepen/jsfiddle, and the bug is so obvious.
There is any demo be provided. Sorry about that.
version: vue-router 2.5.3