Workbox pwa plugin #6497
Open
Workbox pwa plugin #6497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding information about omitting publicpath config if you deploy to a custom domain.
Add JSDoc: @type for better editor support. https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html
* Minor change on the staging mode example As a beginner, I was confused with the parentheses staging line of the example. I thought the parentheses were the pattern to make the env variable work. I hope the change that I made could help.
* docs: (ru) config/readme.md update * docs: (ru) eslint.md update * docs: (ru) cli-service.md update * docs: (ru) css.md update * docs: (ru) mode-and-env.md update * docs: (ru) deployment.md update Co-authored-by: Alex Sokolov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
The current vue-cli-plugin-pwa does not support debugging the service worker. For more advanced PWAs, we need to be able to locally debug the service worker in NODE_ENV='development' but serving up the PWA. (See #6457).
This PR is for a new version of the PWA plugin that uses Workbox instead of register-service-worker. I started with the existing pwa plugin and fixed a bug with the Start URL (which should be '/'). Then I removed register-service-worker and added Workbox 6.1.5. I also added the webpack setting to automatically add the PWA's name to the installed PWA's app bar.
Other features include:
Please reach out if you have any questions.