Skip to content

explain what 'trim' does #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2018
Merged

explain what 'trim' does #1912

merged 2 commits into from
Dec 19, 2018

Conversation

smilingkite
Copy link
Contributor

'This trims out white-space from the input. '

'This trims out white-space from the input. '
@phanan
Copy link
Member

phanan commented Dec 18, 2018

Hmm. I believe the sentence right before the example explains the functionality quite well already:

If you want user input to be trimmed automatically, you can add the trim modifier to your v-model managed inputs.

Can you elaborate why/how it doesn't for you?

@smilingkite
Copy link
Contributor Author

smilingkite commented Dec 18, 2018 via email

@chrisvfritz
Copy link
Contributor

chrisvfritz commented Dec 19, 2018

Thanks for this! I agree it's better not to assume familiarity with String.prototype.trim. 🙂 I just made a small tweak to simplify the language.

@chrisvfritz chrisvfritz merged commit 6b00d32 into vuejs:master Dec 19, 2018
@smilingkite smilingkite deleted the patch-1 branch December 20, 2018 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants