chore(router): copy README file from workspace root #2502
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-router canceled.
|
There was a problem hiding this comment.
This used to be handled in release.mjs, but it seems that was removed in e03edfd. Unclear whether that was intentional. Maybe the plan was to handle this like Pinia, which uses a separate, shorter version of its README.md for the npm release?
Not sure which approach posva would prefer for Vue Router.
Comment on lines
+108
to
+109
| "prepack": "cp ../../README.md ./README.md", | ||
| "postpack": "rm ./README.md" |
There was a problem hiding this comment.
I don't think using cp and rm is portable. The package rimraf is already included, which is a portable version of rm. In the past I've used the copyfiles package as a portable replacement for cp.
posva
requested changes
Jun 4, 2025
There was a problem hiding this comment.
@skirtles-code is right, this was an oversight when updating the release script. It should be moved there like it used to be
github-project-automation
bot
moved this from 🧑💻 In progress
to ✅ Done
in Vue Router Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add README to make the package look less bare on npm