Rotate refresh icon #332
Merged
Rotate refresh icon #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
requested changes
May 19, 2017
src/devtools/App.vue
Outdated
| @@ -78,7 +79,13 @@ export default { | |||
| } | |||
| }, | |||
| refresh () { | |||
| this.refreshRotate += 180 | |||
| const refleshIcon = this.$el.querySelector('.refresh-icon') | |||
There was a problem hiding this comment.
you can use a ref on the element instead
posva
reviewed
May 22, 2017
src/devtools/App.vue
Outdated
| bridge.send('refresh') | ||
| bridge.on('flush', () => { |
There was a problem hiding this comment.
I forgot to say that the bridge.on should be setup only once
|
Hi @posva , what do you think about changing the icon? An idea would be to leave the same chrome refresh icon.
|
posva
requested changes
May 23, 2017
src/devtools/global.styl
Outdated
|
|
||
| @-moz-keyframes rotate | ||
| 0% | ||
| -moz-transform rotate(0deg) |
There was a problem hiding this comment.
No need for prefixes because stylus will add them. So keeping the @keyframes rule with only transform is enough
|
@posva , what do you think of these latest changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe it is not the best way to implement, but it would be nice to have a behavior that indicase the refresh.