-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
@vue/compiler-core
import @babel/types
in type definition but missing in dependencies
#6891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's by design I think. If you need TypeScript support then install it by yourself. You can enable |
fixes: vuejs#5625, vuejs#6891, vuejs#8917 Moved @babel/types from dev dependencies to normal dependencies. In this case npm will correctly resolve dependency under configurations described in related issues.
I added PR #10533 solving issue. It seems to come back here a lot (already 3 issues: #5625, #8917, and this) and technically if compiler-core depends on library it should have it in dependencies (as in my PR). Requiring from users adding dev dependencies of some of their dependencies creates confusion, and after some time you end up with a lot of dependencies where you don't know anymore if it's needed or was added to fix some missing transitive dep. |
See #10533 (comment) |
Uh oh!
There was an error while loading. Please reload this page.
Vue version
3.2.41
Link to minimal reproduction
https://github.com/trim21/vue-compile-core-missing-deps
there is a vue type shim
Steps to reproduce
git clone https://github.com/trim21/vue-compile-core-missing-deps cd vue-compile-core-missing-deps npm i npx tsc --noEmit
What is expected?
tsc type checking ok
What is actually happening?
System Info
doesn't matter
Any additional comments?
This is fixed with
@babel/types
in deps.The text was updated successfully, but these errors were encountered: