Skip to content

fix: resolve directives in nested scopes #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

KaelWD
Copy link
Contributor

@KaelWD KaelWD commented May 14, 2025

🤔 What is the nature of this change?

  • New feature
  • Fix bug
  • Style optimization
  • Code style optimization
  • Performance optimization
  • Build optimization
  • Refactor code or style
  • Test related
  • Other

💡 Background or solution

directives in slots were still using resolveDirective

import vFoo

// withDirectives(..., [[vFoo]])
<A v-foo>
  {{
    default: () => (
      // withDirectives(..., [[resolveDirective('foo')]])
      <B v-foo />
    )
  }}
</A>

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

netlify bot commented May 14, 2025

Deploy Preview for vue-jsx-explorer ready!

Name Link
🔨 Latest commit 5e2c8e1
🔍 Latest deploy log https://app.netlify.com/projects/vue-jsx-explorer/deploys/6834119c37f3a70007807eb7
😎 Deploy Preview https://deploy-preview-759--vue-jsx-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant