fix: process.env members could be undefined, abstract into RustEnv …
#49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icyJoseph
commented
Sep 7, 2021
| @@ -67,6 +70,10 @@ async function runUserScripts(entrypoint: string) { | |||
| } | |||
| } | |||
|
|
|||
| function isExecaError(err: Error): err is ExecaError { | |||
There was a problem hiding this comment.
Have to roll out our own type guard to make sure we are dealing with an ExecaError
icyJoseph
commented
Sep 7, 2021
| } | ||
| throw e; |
There was a problem hiding this comment.
Should always re throw? I think?
That would be amazing 😄 |
leerob
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Really cool project!
I've started to familiarize with the code base, so here are some type fixes for #47.
What do we think of upgrading to TS 4.4.x?