Skip to content

docs: fix OpenTelemetry documentation #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025

Conversation

mkmkme
Copy link
Collaborator

@mkmkme mkmkme commented Jun 11, 2025

There's no opentelemetry-instrumentation-valkey as of now, although it is WIP [1]. Fix the link for now, we can revert it later.

Fixes #190

[1] open-telemetry/opentelemetry-python-contrib#3478

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.26%. Comparing base (4f81c56) to head (cae1f87).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   76.27%   76.26%   -0.01%     
==========================================
  Files         130      130              
  Lines       33983    33983              
==========================================
- Hits        25919    25917       -2     
- Misses       8064     8066       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bogdanp05
bogdanp05 previously approved these changes Jun 12, 2025
@mkmkme
Copy link
Collaborator Author

mkmkme commented Jun 12, 2025

It appears that spellcheck has failed. Looking into it

@mkmkme mkmkme added this to the 6.1.1 milestone Jun 12, 2025
mkmkme and others added 2 commits June 12, 2025 14:40
There's no opentelemetry-instrumentation-valkey as of now, although it
is WIP [1]. Fix the link for now, we can revert it later.

[1] open-telemetry/opentelemetry-python-contrib#3478

Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Ahmed Sobeh <[email protected]>
Signed-off-by: Mikhail Koviazin <[email protected]>
@ahmedsobeh
Copy link
Collaborator

It appears that spellcheck has failed. Looking into it

I made the needed change, you'll just need to force push

@mkmkme
Copy link
Collaborator Author

mkmkme commented Jun 12, 2025

@ahmedsobeh thanks!

@mkmkme mkmkme force-pushed the mkmkme/documentation-opentelemetry-fix branch from 076f35a to cae1f87 Compare June 12, 2025 12:53
@mkmkme mkmkme enabled auto-merge June 12, 2025 14:30
@mkmkme mkmkme merged commit e9104ed into main Jun 12, 2025
85 checks passed
@mkmkme mkmkme deleted the mkmkme/documentation-opentelemetry-fix branch June 12, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no opentelemetry-instrumentation-valkey
4 participants