Skip to content

fix: Do not trigger extra TS checks (#16523) (CP: 23.3) #16525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

Fixes the sometimes constant output stream of 
```
[TypeScript] Found 0 errors. Watching for file changes.
```

The relevant fix in TypeScript is microsoft/TypeScript#51626
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) April 4, 2023 10:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Test Results

   954 files  ±0     954 suites  ±0   53m 42s ⏱️ + 3m 18s
6 206 tests ±0  6 158 ✔️ ±0  48 💤 ±0  0 ±0 
6 466 runs   - 5  6 410 ✔️  - 5  56 💤 ±0  0 ±0 

Results for commit e4951af. ± Comparison against base commit 2595da7.

@vaadin-bot vaadin-bot merged commit 457e92f into 23.3 Apr 4, 2023
@vaadin-bot vaadin-bot deleted the cherry-pick-16523-to-23.3-1680602637038 branch April 4, 2023 10:33
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 23.3.11.

@vaithu
Copy link

vaithu commented Apr 6, 2023

Yes this released fixed the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants