Add better typings plus test for transaction.atomic. #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
syastrov
commented
Feb 19, 2019
syastrov
commented
- All cases are handled, including bare decorator (@transaction.atomic).
- Decorated function's signature is preserved when type-checking.
|
Thank you very much for the PR! Tests for the plugin are extremely slow now, mypy need to load lots of stuff in memory on every test. Could you combine all three your tests into a big one? |
syastrov
force-pushed
the
better-types-for-transaction-atomic
branch
from
97b651c to
ad9363c
Compare
|
You are welcome. I've merged the tests into one. And I removed some stuff that shouldn't have been in the changes that caused failing tests. I have force-pushed my changes. |
|
Looks really good, run |
- All cases are handled, including bare decorator (@transaction.atomic). - Decorated function's signature is preserved when type-checking.
syastrov
force-pushed
the
better-types-for-transaction-atomic
branch
from
ad9363c to
67c9943
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.