Make it possible to construct a Response #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Emilgardis
commented
May 7, 2023
Emilgardis
commented
- add Response::new and Response::with_data
- Use the new methods for Response
Emilgardis
commented
May 7, 2023
| data: CreateEventSubSubscription { | ||
| Ok(helix::Response::with_data( | ||
| CreateEventSubSubscription { | ||
| // helix::Response total is generally the total number of results, not what the total for this endpoint means. Thus, we set it to None.)) |
There was a problem hiding this comment.
should fix this comment
Emilgardis
commented
May 7, 2023
Comment on lines
+103
to
+116
| /// # Examples | ||
| /// | ||
| /// ```rust | ||
| /// use twitch_api::helix::{self, Request, RequestPut}; | ||
| /// | ||
| /// #[derive(serde::Serialize, Debug, PartialEq)] | ||
| /// pub struct MyTwitchRequest {} | ||
| /// | ||
| /// #[derive(serde::Deserialize, Debug, PartialEq)] | ||
| /// pub enum MyTwitchResponse { | ||
| /// Success, | ||
| /// } | ||
| /// | ||
| /// impl Request for MyTwitchRequest { |
There was a problem hiding this comment.
this example could probably also be added to Request
|
going to try this to see that the merge queue is working, this pr should fail since #368 is merged |
|
hmm, skipped = success.... |
|
solved with #372 i hope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.