Skip to content

Fix for factory methods removed from mlir::FloatType. #5664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix for factory methods removed from mlir::FloatType. #5664

wants to merge 1 commit into from

Conversation

chsigg
Copy link
Collaborator

@chsigg chsigg commented Jan 21, 2025

@chsigg chsigg requested a review from ptillet as a code owner January 21, 2025 14:16
Jokeren
Jokeren reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@Jokeren Jokeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also clean up methods like isFloat and isFloat8?

@makslevental
Copy link
Contributor

I have a commit (that I'm going to turn into a PR) that handles all of these integrations after upstream changes. If you want to wait I can send it tomorrow (after this one lands "thoroughly").

@chsigg
Copy link
Collaborator Author

chsigg commented Jan 22, 2025

Those are two independent upstream changes and could have landed separately, but if Maksim already has them ready, I will leave it to him.

@chsigg chsigg closed this Jan 22, 2025
@makslevental makslevental mentioned this pull request Jan 23, 2025
Merged
peterbell10 pushed a commit that referenced this pull request Jan 29, 2025
@makslevental
[BACKEND] bump to llvm/llvm-project@c118864223c6 (#5684)
9a49104 
Pulls in llvm/llvm-project#123200 which is
useful and also handles #5664.

Integrations were required due to
llvm/llvm-project#123026,
llvm/llvm-project#123321 and
llvm/llvm-project#123326.

Also closes #5685
makslevental added a commit to makslevental/triton that referenced this pull request Feb 19, 2025
@makslevental
[BACKEND] bump to llvm/llvm-project@c118864223c6 (triton-lang#5684)
d7ab82c 
Pulls in llvm/llvm-project#123200 which is
useful and also handles triton-lang#5664.

Integrations were required due to
llvm/llvm-project#123026,
llvm/llvm-project#123321 and
llvm/llvm-project#123326.

Also closes triton-lang#5685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jokeren Jokeren Jokeren left review comments

@ptillet ptillet Awaiting requested review from ptillet ptillet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chsigg @makslevental @Jokeren